YOUR ACCOUNT

Home > Forums > Beta 14.0 > 

VARIATION global is broken

Active Topics Search
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
The VARIATION global variable in scripting is broken - it always contain the value 1, regardless of the variation slider setting.
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 16, 2013 5:29 am   Details E-Mail
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
While I'm at it - how do you add a variation input to a script that is influenced by the global variation variable (the same way as in noises etc)?
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 16, 2013 7:56 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Quoted from the Scripting API help article:

Quote
API Variables

VARIATION – the value of the global Variation slider. Available only to scripts that have the Makes use of the global Variation setting flag turned on in their Script Settings.
Posted: March 16, 2013 11:46 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Quote
While I'm at it - how do you add a variation input to a script that is influenced by the global variation variable (the same way as in noises etc)?


Just add a regular IntSlider input and use it. You have to code the influence manually.
Posted: March 16, 2013 11:46 am   Details E-Mail
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
It wouldn't be broken if I forgot to set that option smile;-) I attached a filter so you can test it this time.
-
I'd like to see how you implement that IntSlider and Global Variation concept - I don't understand how you can mimic the general variation behavior this way.

Broken VARIATION.ffxml
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 16, 2013 2:05 pm   Details E-Mail
Bionic
Posts: 134
There's another bug here guys hence you cannot open file on first attempt from forum.

<class XFW::StateError> Unable to set rendering storage while rendering is in progress (rendering manager 04974968).

At a second attempt it would load fine, move file off your system Spinx & you'll see.

"Broken VARIATION.ffxml" must not be present in your filters and FF should be closed to reproduce this error.

Then click your own posted "Broken VARIATION.ffxml"

I generated a report for this error.

[ dump.txt ]
Posted: March 16, 2013 6:32 pm   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
I didn't inspect the filter myself, but as the programmers tell me, you're returning the value of VARIATION as a color. It's an integer variable so when converted to a color it will have HDR values (1, 2, 3 etc.) If so, you should uncheck Filter > Anti-Aliasing > Clip HDR Before Averaging to make sure the result isn't getting clipped into the 0...1 range.

(Also make sure that the script you're outputting it from has HDR enabled in its Settings, otherwise you'll get clipping regardless of the value of "Clip HDR Before Averaging").
Posted: March 17, 2013 4:27 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Quote
I'd like to see how you implement that IntSlider and Global Variation concept - I don't understand how you can mimic the general variation behavior this way.


In the C++ code for FF components, we just XOR the global and local variation values to get the resulting seed. I'm not sure if Lua supports bitwise ops though (if so you may try adding or multiplying them).
Posted: March 17, 2013 4:38 am   Details E-Mail
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
Okay, that HDR clipping doubletricked me into believing it was the variation variable that was the culpritt when I tried to simplify the issue (and moreover it tricked me into believing it was reproduce).

The attached filter shows the real deal - the problem might not be variation but set_noise_seed or the get_noise function itself (it was in a more advanced version of this I ran into the problem):

Code

function prepare()
   set_noise_seed(VARIATION)
end;

function get_sample(x, y)
   local v = get_noise(x,y,1)
   return v,v,v,1
end;


VARIATION Issue.ffxml
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 17, 2013 5:07 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
I was able to render it perfectly fine, see the attached picture.

What is the problem?
Posted: March 17, 2013 5:23 am   Details E-Mail
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
Thanks for the variation explanation - for some unknown reason I thought you only applied global variation to components with no manual variation control hooked up, but I see its not the case (and it wouldn't make much sense either).
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 17, 2013 5:27 am   Details E-Mail
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
The problem is that changes to global variation don't affect the rendering smile:D
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 17, 2013 5:27 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Yes, found it out later.

Here's the solution:

set_noise_seed(VARIATION + 1)

For some reason, it doesn't work when I pass VARIATION without adding 1 (or anything for that matter, like the local Variation setting). I'm assigning this to programmers.
Posted: March 17, 2013 5:29 am   Details E-Mail
Sphinx.
Filter Optimizer

Posts: 1750
Filters: 39
Hurray smile:-D And thanks.
Njyldgarkn init/prepare process x no. of render blocks x no. of passes
Posted: March 17, 2013 5:30 am   Details E-Mail
GMM
Moderator
Filter Forge, Inc
Posts: 3491
Vladimir, does it count as a for-point bug report?
Posted: March 18, 2013 4:40 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Quote
<class XFW::StateError> Unable to set rendering storage while rendering is in progress (rendering manager 04974968).


Bionic, we can't reproduce this error. Could you post detailed step-by-step instructions?
Posted: March 18, 2013 6:47 am   Details E-Mail
GMM
Moderator
Filter Forge, Inc
Posts: 3491
Vladimir and Bionic, "Unable to set rendering storage" is a long known issue that dates back to 2011.
Posted: March 18, 2013 7:22 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
We could not reproduce it using these instructions, so we're still waiting for a step-by-step from Bionic.
Posted: March 18, 2013 8:45 am   Details E-Mail
GMM
Moderator
Filter Forge, Inc
Posts: 3491
I am able to reproduce using 4.002 but not 4.003.
Posted: March 18, 2013 8:50 am   Details E-Mail
Bionic
Posts: 134
Quote
I am able to reproduce using 4.002 but not 4.003.

Yep, that's the build I've used - 4.002.2758

I searched for similar issues and ended up with 2 old results - FF3.
You should be able to reproduce this using build 4.002.2758.

GMM, when I try to open this old post from CFandM dated 2011 I get a different error in FF 4.002.2758 Bug 2011

<class XFW::ArgumentError> No storage item with id = C:\Documents and Settings\CFandM\My Documents\My Pictures\Fuji Picts\Bugs\DSCF2288.jpg in DataExchangeStorage 0191FC40

I'll submit in case it's something new that can be fixed.

[ dump - CFandM dated 2011.txt ]
Posted: March 18, 2013 12:36 pm   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Bionic, can you reproduce it in 4.003?
Posted: March 19, 2013 8:04 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Quote
Vladimir, does it count as a for-point bug report?


Sphinx's submission about the VARIATION / VARIATION + 1 thing? Yes.
Posted: March 19, 2013 8:16 am   Details E-Mail
Bionic
Posts: 134
Vladimir, errors from Sphinx and also CFandM are gone in 4.003 when opening their attachments.
Posted: March 19, 2013 8:36 am   Details E-Mail
Vladimir Golovin
Administrator
Posts: 3446
Filters: 55
Good. I'm closing the bug.
Posted: March 19, 2013 9:21 am   Details E-Mail

Join Our Community!

Filter Forge has a thriving, vibrant, knowledgeable user community. Feel free to join us and have fun!

33,712 Registered Users
+19 new in 30 days!

153,533 Posts
+31 new in 30 days!

15,348 Topics
+73 new in year!

Create an Account

Online Users Last minute:

31 unregistered users.

Recent Forum Posts:

Join our Forum Join our Forum
Over 30 000 members!
Join us on Facebook Join us on Facebook
Over 42 000 likes!
Follow us on Twitter Follow us on Twitter
Get updates quickly!
Follow us on Instagram Follow us on Instagram
Tag us #filterforge